[PATCH 3/4] virscsi: Drop @tmp from virSCSIDeviceListDel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Clang on Rawhide started to complain that @tmp variable in
virSCSIDeviceListDel() is set but not used. This is obviously a
false positive because the variable is used to free device stolen
from the list. Anyway, we can do without the variable so in this
specific case let's fix our code to appease Clang.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
 src/util/virscsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/util/virscsi.c b/src/util/virscsi.c
index 2488b0e5f8..6a90d9002f 100644
--- a/src/util/virscsi.c
+++ b/src/util/virscsi.c
@@ -414,8 +414,7 @@ virSCSIDeviceListDel(virSCSIDeviceList *list,
                 virSCSIDeviceUsedByInfoFree(dev->used_by[i]);
                 VIR_DELETE_ELEMENT(dev->used_by, i, dev->n_used_by);
             } else {
-                g_autoptr(virSCSIDevice) tmp = NULL;
-                tmp = virSCSIDeviceListSteal(list, dev);
+                virSCSIDeviceFree(virSCSIDeviceListSteal(list, dev));
             }
             break;
         }
-- 
2.31.1




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux