Re: [PATCHv2 6/6] tests: add test on virNetDevOpenvswitchInterfaceSetQos and virNetDevOpenvswitchInterfaceClearQos

[Michal Prívozník <mprivozn@xxxxxxxxxx>]

On 8/17/21 6:38 AM, jx8zjs wrote:
> From: Jinsheng Zhang <zhangjl02@xxxxxxxxxx>
> 
> Test virNetDevOpenvswitchInterfaceSetQos and
> virNetDevOpenvswitchInterfaceClearQos with dryrun method.
> 
> Signed-off-by: zhangjl02 <zhangjl02@xxxxxxxxxx>
> ---
>  tests/virnetdevopenvswitchtest.c | 196 ++++++++++++++++++++++++++++++-
>  1 file changed, 195 insertions(+), 1 deletion(-)
> 


> -VIR_TEST_MAIN(mymain);
> +VIR_TEST_MAIN_PRELOAD(mymain, VIR_TEST_MOCK("virnetdevbandwidth"))

Nit pick - here we like to put VIR_TEST_MOCK() on a separate line.

And huge thank you for introducing the test. It was on my todo list.

Michal