2010/3/15 Daniel P. Berrange <berrange@xxxxxxxxxx>: > On Mon, Mar 15, 2010 at 02:29:55PM +0100, Matthias Bolte wrote: >> 2010/3/15 Daniel P. Berrange <berrange@xxxxxxxxxx>: >> > On Sun, Mar 14, 2010 at 10:07:24PM +0100, Matthias Bolte wrote: >> >> --- >> >> src/esx/esx_driver.c | 8 ++-- >> >> src/esx/esx_util.c | 83 ---------------------------------------------- >> >> src/esx/esx_util.h | 7 ---- >> >> src/util/util.c | 89 ++++++++++++++++++++++++++++++++++++++++++++++++++ >> >> src/util/util.h | 5 +++ >> >> 5 files changed, 98 insertions(+), 94 deletions(-) >> > >> > ACK in principle, but I think we should start a new file for these helpers, >> > rather than continue to add more to 'util.c' since it is getting rather large. >> > Lets keep util.c/h for POFIX file/path/process related wrappers. >> > >> >> Okay, any suggestion for a filename? > > How about util/authhelper.c > > Regards, > Daniel > Yep, that's fine. I'm going to move the code to that file, add the new file to Makefile.am, and push the patch then. Matthias -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list