On Tue, 2021-08-17 at 14:18 +0200, Martin Kletzander wrote: > On Mon, Aug 16, 2021 at 07:19:48PM +0800, Luke Yue wrote: > > Signed-off-by: Luke Yue <lukedyue@xxxxxxxxx> > > --- > > examples/xml/test/testdevcontroller.xml | 1 + > > examples/xml/test/testdevdiskcdrom.xml | 5 +++ > > examples/xml/test/testdevfs.xml | 6 ++++ > > examples/xml/test/testdevhostdev.xml | 5 +++ > > examples/xml/test/testdevif.xml | 6 ++++ > > This one and ... > > > examples/xml/test/testdevinput.xml | 1 + > > examples/xml/test/testdevlease.xml | 5 +++ > > examples/xml/test/testdevmem.xml | 6 ++++ > > examples/xml/test/testdevnetif.xml | 6 ++++ > > ... this one only differ in MAC addresses, but the names suggest > something else. Since this commit does not use them anywhere it is > difficult to see if they are both useful or not. > > Consider adding these in a commit where they are being used. Sorry for that, one of them is for attach APIs, and was added by accident, will delete it in v2.