Hi, On 2021/8/17 17:21, Martin Kletzander wrote: > On Tue, Aug 17, 2021 at 10:55:24AM +0800, Zhenyu Ye wrote: >> commit 2e668a61d5ae4("Fix error handling when adding MCS labels") uses >> the 'pctx' in virReportError after it has been freed. Fix it. >> >> Fixes: 2e668a61d5ae4cbd6f79e096d0c394f186e132bd >> Signed-off-by: eillon <yezhenyu2@xxxxxxxxxx> > > Thanks for fixing a 9 year old bug =) One thing I am not sure about is > the sign off. According to the Project Governance [0] states: > > "... for contributing patches, providing a 'Signed-off-by' line with > the author's legal name and e-mail address to demonstrate agreement > and compliance with the Developer Certificate of Origin is required." > > Which I am not sure you maybe misconfigured somehow? Just let me know > whether I should change "eillon" to "Zhenyu Ye" and I can fix that > before pushing the patch, or coreect me if I misunderstood. No need to > send another version. > > Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx> > Thanks, help me change the "eillon" to "Zhenyu Ye". Zhenyu