Re: [libvirt PATCH 2/5] vsh: cmdEcho: use separate variable for argument

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 10, 2021 at 19:14:40 +0200, Ján Tomko wrote:
> Do not use 'arg' which is later used for an allocated string.
> 
> Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>
> ---
>  tools/vsh.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

There's quite some room for rewriting the code to even avoid the use of
temps and string copies though.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux