Re: [PATCH 00/13] Clean up string list freeing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a %A in %Y, Peter Krempa wrote:
> Switch remaining users of virStringListFreeCount to g_auto(GStrv) and
> clean up some usage of string lists.
> 
> Depends on the refactor of the virtual function code I've posted
> earlier.
> 
> Pipeline:
> 
> https://gitlab.com/pipo.sk/libvirt/-/pipelines/348627403
> 
> Peter Krempa (13):
>   testQemuAgentSSHKeys: Refactor cleanup
>   remote: dispatch: Don't use virStringListFreeCount for NULL terminated
>     lists
>   qemu: firmware: Store machine types as a NULL-terminated string list
>   qemu: domain: Store passthrough environment variables in a struct
>   qemu: domain: Store capability overrides in NULL-terminated string
>     list
>   qemu: domain: Store passthrough arguments in NULL-terminated string
>     list
>   network: bridge: Store dnsmasq passthrough options in NULL-terminated
>     string list
>   qemuNamespacePrepareOneItem: Restructure code to avoid temporary
>     variables
>   qemuNamespacePrepareOneItem: Don't pass count of elements
>   qemuNamespaceMknodPaths: Remove 'ndevMountsPath'
>   qemuDomainUnshareNamespace: Use automatic memory clearing for string
>     lists
>   lxcContainerSetReadOnly: Refactor cleanup handling
>   util: virstring: Remove unused virStringListFreeCount
> 
>  src/libvirt_private.syms            |  1 -
>  src/lxc/lxc_container.c             | 27 ++++-----
>  src/network/bridge_driver.c         | 23 ++++----
>  src/qemu/qemu_command.c             |  9 +--
>  src/qemu/qemu_domain.c              | 91 +++++++++++++++--------------
>  src/qemu/qemu_domain.h              | 12 ++--
>  src/qemu/qemu_firmware.c            |  4 +-
>  src/qemu/qemu_namespace.c           | 46 ++++++---------
>  src/qemu/qemu_process.c             | 13 ++---
>  src/remote/remote_daemon_dispatch.c |  8 +--
>  src/util/virstring.c                | 23 --------
>  src/util/virstring.h                |  3 -
>  tests/qemuagenttest.c               | 54 ++++++++---------
>  13 files changed, 135 insertions(+), 179 deletions(-)
> 

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux