Re: [PATCH 5/7] conf: Store SCSI bus length in virDomainDef

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a %A in %Y, Michal Privoznik wrote:
> Libvirt assumes that a SCSI bus can fit up to 8 devices
> (including controller itself), except for so called wide bus
> which can accommodate up to 16 devices (again, including
> controller). This plays important role when computing 'drive'
> address in virDomainDiskDefAssignAddress(). So far, the only
> driver that enables wide SCSI bus is VMX. But with never

s/never/newer/

Jano

> releases, ESX is capable of "super wide" bus (64 devices).
> 
> We can blindly bump the limit in our code because then we would
> compute address that's invalid for older ESX versions that we
> still want to support.
> 
> Unfortunately, I haven't found a better place where to store this
> than virDomainDef.
> > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
>  src/bhyve/bhyve_parse_command.c |  2 +-
>  src/conf/domain_conf.c          | 33 ++++++++++++++-------------------
>  src/conf/domain_conf.h          |  9 ++++++++-
>  src/hyperv/hyperv_driver.c      |  4 ++--
>  src/libxl/libxl_driver.c        |  2 +-
>  src/libxl/xen_xl.c              |  2 +-
>  src/libxl/xen_xm.c              |  2 +-
>  src/lxc/lxc_native.c            |  2 +-
>  src/openvz/openvz_conf.c        |  2 +-
>  src/qemu/qemu_process.c         |  2 +-
>  src/vbox/vbox_common.c          |  8 ++++----
>  src/vmx/vmx.c                   |  2 +-
>  src/vz/vz_sdk.c                 |  2 +-
>  tests/genericxml2xmltest.c      |  2 +-
>  tests/openvzutilstest.c         |  2 +-
>  tests/qemublocktest.c           |  2 +-
>  tests/qemumonitortestutils.c    |  2 +-
>  tests/securityselinuxtest.c     |  2 +-
>  18 files changed, 42 insertions(+), 40 deletions(-)
> 




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux