On Wed, Aug 04, 2021 at 11:19:35AM +0200, Pavel Hrdina wrote: > On Wed, Aug 04, 2021 at 10:09:30AM +0100, Daniel P. Berrangé wrote: > > On Tue, Aug 03, 2021 at 04:29:32PM +0200, Pavel Hrdina wrote: > > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > > > --- > > > docs/formatdomain.rst | 13 +++++++++++++ > > > docs/schemas/domaincommon.rng | 11 +++++++++++ > > > src/conf/domain_conf.c | 5 +++++ > > > src/conf/domain_conf.h | 2 ++ > > > src/conf/domain_validate.c | 19 +++++++++++++++++++ > > > tests/genericxml2xmlindata/vmid.xml | 19 +++++++++++++++++++ > > > tests/genericxml2xmltest.c | 2 ++ > > > 7 files changed, 71 insertions(+) > > > create mode 100644 tests/genericxml2xmlindata/vmid.xml > > > > > diff --git a/tests/genericxml2xmlindata/vmid.xml b/tests/genericxml2xmlindata/vmid.xml > > > new file mode 100644 > > > index 0000000000..df984df3f5 > > > --- /dev/null > > > +++ b/tests/genericxml2xmlindata/vmid.xml > > > @@ -0,0 +1,19 @@ > > > +<domain type='qemu'> > > > + <name>QEMUGuest1</name> > > > + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> > > > + <memory unit='KiB'>219100</memory> > > > + <currentMemory unit='KiB'>219100</currentMemory> > > > + <vcpu placement='static'>4</vcpu> > > > + <os> > > > + <type arch='x86_64' machine='q35'>hvm</type> > > > + <boot dev='hd'/> > > > + </os> > > > + <clock offset='utc'/> > > > + <vmid>someapp:c7a5fdbd-edaf-9455-926a-d65c16db1809</vmid> > > > > I'm not convinced by adding this element here with this name. > > > > It is rather too generic and doesn't really give any suggestion > > as to what it is used for. > > I was struggling with that as well. To be honest I don't know where to > put it. In downstream BZ there was suggestion to place it under > <blkiotune> but this is not tunning any IO so I don't thing it should > belong there. We can move it closer to UUID and GENID and all this ID > elements. Any idea is welcome :). I'm struggling to find info on what this attribute actally does in practice, and/or what format it is required to be in. I was wondering what would happen if we simply wrote the VM UUID into this attribute unconditionally, and thus avoid need for an XML element ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
