On 8/3/21 5:13 PM, Ján Tomko wrote: > v2 of: > https://listman.redhat.com/archives/libvir-list/2021-June/msg00570.html > > Ján Tomko (6): > virProcessKillPainfullyDelay: use 'rc' variable > util: Introduce virProcessGroupKill > util: introduce virProcessGroupGet > util: virPidFileForceCleanupPath: add group argument > qemu: virtiofs: kill the whole process group > util: fix typo > > src/libvirt_private.syms | 1 + > src/qemu/qemu_process.c | 3 ++- > src/qemu/qemu_virtiofs.c | 2 +- > src/util/virpidfile.c | 15 ++++++++++-- > src/util/virpidfile.h | 2 ++ > src/util/virprocess.c | 53 +++++++++++++++++++++++++++++++++++----- > src/util/virprocess.h | 5 +++- > 7 files changed, 70 insertions(+), 11 deletions(-) > I think you split code into too many patches. If you squash some together you have my: Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> Michal
