Re: [libvirt PATCH] schema: make target mandatory for filesystems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 27, 2021 at 01:13:18PM +0200, Ján Tomko wrote:
Commit 12967c3e13 incorrectly made the target optional.
The validation was re-introduced by commit e8863b91f (which
put it into FSDefValidate instead of the parser), but
it did not amend the schema to make it mandatory again.

https://bugzilla.redhat.com/show_bug.cgi?id=1969232

Fixes: e8863b91fb98f077d4c44a11bd7ea84c5e6b29ef
Signed-off-by: Ján Tomko <jtomko@xxxxxxxxxx>

Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx>

---
docs/schemas/domaincommon.rng | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index 14c5d4ee68..2442078969 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -2859,12 +2859,10 @@
          </group>
        </choice>
        <interleave>
-          <optional>
-            <element name="target">
-              <attribute name="dir"/>
-              <empty/>
-            </element>
-          </optional>
+          <element name="target">
+            <attribute name="dir"/>
+            <empty/>
+          </element>
          <optional>
            <attribute name="accessmode">
              <choice>
--
2.31.1

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux