Re: [PATCH v5 00/11] Support for launchSecurity type s390-pv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/21/21 12:04 PM, Pavel Hrdina wrote:
On Fri, Jul 16, 2021 at 11:44:24AM +0200, Boris Fiuczynski wrote:
This patch series introduces the launch security type s390-pv.
Specifying s390-pv as launch security type in an s390 domain prepares for
running the guest in protected virtualization secure mode, also known as
IBM Secure Execution.

diff to v4:
  - changed rng to do the verification for every launchSecurity type
  - removed previously added XML fail tests
  - added domain capability documentation

diff to v3:
  - rebased to current master
  - moved virDomainSEVDef into a union
  - improved XML formating for launchSecurity
  - use a shared id on the qemu cmd line for confidential-guest-support
  - added check for s390-pv host support into XML validation
  - changed from ignoring to failing if launchSecuroty child elements are provided for s390-pv
  - reduced test to  a single failing test
  - add availability of s390-pv in domain capabilities

diff to v2:
  - broke up previous patch one into three patches

diff to v1:
  - rebased to current master
  - added verification check for confidential-guest-support capability

Boris Fiuczynski (11):
   schemas: Refactor launch security
   conf: Rework SEV XML parse and format methods
   qemu: Make KVMSupportsSecureGuest capability available
   conf: Refactor launch security to allow more types
   qemu: Add s390-pv-guest capability
   conf: Add s390-pv as launch security type
   docs: Add s390-pv documentation
   conf: Add availability of s390-pv in domain capabilities
   docs: Add s390-pv in domain capabilities documentation
   qemu: Use common id lsec0 for launchSecurity
   qemu: Fix error code for SEV launchSecurity unsupported

I can make the changes before pushing if you are agree with the pointed
issues.

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Hi Pavel,
thanks for your review.
The agree with the changes you pointed out.
Please also apply the fixup patch I sent for patch 9. Thanks


--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux