Re: [PATCH v2 0/3] Do not erase duplicate devices from namespace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/14/21 4:46 PM, Kristina Hanicova wrote:
> This is v2 of:
> https://listman.redhat.com/archives/libvir-list/2021-July/msg00129.html
> 
> Changes since v1 (suggested by Michal and Jano):
> * change of int variable to one-word bool
> * isolate changes outside of qemu to separate patch
> * rewritten assignment of return value
> * slight change of documentation
> * extension of use to all devices, not just input
> * @created variable is set in one core function instead of setting it in
>   each device function separately
> 
> Kristina Hanicova (3):
>   qemu: Check for existing file in namespace
>   virprocess: Return retval of the child on success, not 0
>   qemu: Do not erase duplicate devices from namespace if error occurs
> 
>  src/qemu/qemu_domain.c    |  4 +--
>  src/qemu/qemu_hotplug.c   | 27 +++++----------
>  src/qemu/qemu_namespace.c | 71 +++++++++++++++++++++++++--------------
>  src/qemu/qemu_namespace.h | 18 ++++++----
>  src/qemu/qemu_process.c   |  2 +-
>  src/util/virprocess.c     | 12 ++++---
>  6 files changed, 75 insertions(+), 59 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

and pushed.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux