Re: [libvirt PATCH 1/2] docs: point go imports to gitlab.com repos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jul 2, 2021 at 8:35 AM Andrea Bolognani <abologna@xxxxxxxxxx> wrote:
>
> On Fri, Jul 02, 2021 at 11:54:54AM +0100, Daniel P. Berrangé wrote:
> >          <xsl:if test="$pagesrc = 'docs/libvirt-go.rst'">
> > -          <meta name="go-import" content="libvirt.org/libvirt-go git https://libvirt.org/git/libvirt-go.git"/>
> > +          <meta name="go-import" content="libvirt.org/libvirt-go git https://gitlab.com/libvirt/libvirt-go"/>
> >          </xsl:if>
> >          <xsl:if test="$pagesrc = 'docs/libvirt-go-xml.rst'">
> > -          <meta name="go-import" content="libvirt.org/libvirt-go-xml git https://libvirt.org/git/libvirt-go-xml.git"/>
> > +          <meta name="go-import" content="libvirt.org/libvirt-go-xml git https://gitlab.com/libvirt/libvirt-go-xml"/>
> >          </xsl:if>
>
> I believe in terms of git commands it's more appropriate to use
>
>   https://gitlab.com/libvirt/libvirt-go.git
>   https://gitlab.com/libvirt/libvirt-go-xml.git
>
> but both will work due to redirects and such. So either way
>
>   Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
>

The redirects have not consistently worked in the past, so I would ask
that you use the .git URLs Andrea mentioned.


-- 
真実はいつも一つ!/ Always, there's only one truth!





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux