On 6/30/21 4:16 PM, Michal Prívozník wrote: > On 6/10/21 8:15 PM, Jonathon Jongsma wrote: >> Due to a rather unfortunate misunderstanding, we were parsing the list >> of defined devices from mdevctl incorrectly. Since my primary >> development machine only has a single device capable of mdevs, I >> apparently neglected to test multiple parent devices and made some >> assumptions based on reading the mdevctl code. These assumptions turned >> out to be incorrect, so the parsing failed when devices from more than >> one parent device were returned. >> >> The details: mdevctl returns an array of objects representing the >> defined devices. But instead of an array of multiple objects (with each >> object representing a parent device), the array always contains only a >> single object. That object has a separate property for each parent >> device. >> >> Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> >> --- >> src/node_device/node_device_driver.c | 41 ++++++++++--------- >> .../mdevctl-list-multiple.json | 4 +- >> 2 files changed, 23 insertions(+), 22 deletions(-) > > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > > My apologies for not reviewing earlier. Will push after the release. Pushed now. Michal
