Re: [PATCH 3/4] qemu: interface: remove setting noqueue for ovs port

[Michal Prívozník <mprivozn@xxxxxxxxxx>]

On 6/28/21 11:18 AM, zhangjl02 wrote:
> From: zhangjl02 <zhangjl02@xxxxxxxxxx>
> 
> Return 0 directly if the port is ovs managed. When the ovs port is set
> noqueue, qos config on this port will not work.
> ---
>  src/qemu/qemu_domain.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index da5a226fc2..2e8236ce7c 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -11526,6 +11526,8 @@ qemuDomainInterfaceSetDefaultQDisc(virQEMUDriver *driver,
>          actualType == VIR_DOMAIN_NET_TYPE_NETWORK ||
>          actualType == VIR_DOMAIN_NET_TYPE_BRIDGE ||
>          actualType == VIR_DOMAIN_NET_TYPE_DIRECT) {
> +        if (qemuDomainDefIsOvsport(net, actualType))
> +            return 0;
>          if (virNetDevBandwidthSetRootQDisc(net->ifname, "noqueue") < 0)
>              return -1;
>      }
> 

How about:

if (!qemuDomainDefIsOvsport() &&
    virNetDevBandwidthSetRootQDisc() < 0)
    return -1;

Michal