On Wed, 2021-06-23 at 00:09 +0200, Martin Kletzander wrote: > [Another one of those lost e-mails] > > On Wed, Jun 16, 2021 at 05:23:36PM +0800, Luke Yue wrote: > > On Tue, 2021-06-15 at 10:09 +0200, Martin Kletzander wrote: > > > On Mon, Jun 14, 2021 at 09:13:17PM +0800, Luke Yue wrote: > > > > Signed-off-by: Luke Yue <lukedyue@xxxxxxxxx> > > > > --- > > > > src/test/test_driver.c | 53 > > > > ++++++++++++++++++++++++++++++++++++++++++ > > > > 1 file changed, 53 insertions(+) > > > > > > > > > > Similarly to the other patch with virDomainGetSecurityLabelList() > > > this > > > one should also test the added code. > > > > > > Thanks, > > > Martin > > > > I will try to add test in v2, thanks! > > > > You might need to add an extra VM to the default test driver setup > which has > some taint or something so that it is nicer to test. We will need to > add more > in the future in any case, not all new APIs will be testable with the > current > limited set. Just sent v2 patches, for taint messages we don't need an extra VM (but deprecation messages may need). I will add more in the future when it's required for testing new APIs.
