Re: [libvirt PATCH 6/7] nodedev: Implement virNodeDeviceIsPersistent()/IsActive()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/22/21 5:08 PM, Jonathon Jongsma wrote:
On Tue, Jun 22, 2021 at 10:03 AM Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx> wrote:

On 6/22/21 4:33 PM, Jonathon Jongsma wrote:
So it appears that there is a bug where an mdev is still marked as
autostart even after it's undefined. Was there anything else you were
trying to demonstrate?

Jonathon

Don't you need to resync with mdevctl on nodedev-info?
If you would resync and fail to find the definition for the mdev your
bugfix would be to set the autostart to "no". The shortcut would be to
set autostart to "no" when undefine is called but that would leave out
direct usage of mdectl.

Yes, it appears that there's a bug in my patch that needs to be fixed.

But your email said

"The default "yes" seems to be not really a good choice even for mdevs.

That makes it sound like you think there's something more
fundamentally wrong than just a simple bug where a value didn't get
updated properly.

Jonathon


Is the current code resyncing with mdevctl on nodedev-info calls persisted and autostart? Is using mdevctl directly something libvirt needs to worry about with regard to data consistency?

--
Mit freundlichen Grüßen/Kind regards
   Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux