On Fri, Jun 18, 2021 at 15:20:24 +0200, Boris Fiuczynski wrote: > To allow other types of launch security the SEV type specific > parameters like e.g. policy need to be optional and be separated > from other new launch security types. A test is added to ensure > the previously required and now optional launch security policy > remains required when launch security type is SEV. > > Signed-off-by: Boris Fiuczynski <fiuczy@xxxxxxxxxxxxx> > Reviewed-by: Daniel Henrique Barboza <danielhb413@xxxxxxxxx> > --- > docs/schemas/domaincommon.rng | 12 +- > src/conf/domain_conf.c | 156 +++++++++++------- > src/conf/domain_conf.h | 13 +- > src/conf/virconftypes.h | 2 + > src/qemu/qemu_cgroup.c | 4 +- > src/qemu/qemu_command.c | 43 ++++- > src/qemu/qemu_driver.c | 2 +- > src/qemu/qemu_firmware.c | 8 +- > src/qemu/qemu_namespace.c | 20 ++- > src/qemu/qemu_process.c | 35 +++- > src/qemu/qemu_validate.c | 22 ++- > src/security/security_dac.c | 4 +- > ...urity-sev-missing-policy.x86_64-2.12.0.err | 1 + > .../launch-security-sev-missing-policy.xml | 34 ++++ > tests/qemuxml2argvtest.c | 1 + There's a bit too much going on in this single commit. Please split it into appropriate parts.