Eric Blake wrote: > On 03/09/2010 10:02 AM, Eric Blake wrote: >> * cfg.mk (sc_preprocessor_indentation): New syntax-check rule. > > I don't see 1/2 in the archives yet; perhaps it was held up by > moderation, because it is big? (400k) > > At any rate, I've pushed it to my cloned repo, if that makes life any > easier: > http://repo.or.cz/w/libvirt/ericb.git/commitdiff/4d3b7e06bc8e > > Patch 1/2 is entirely mechanical; the most helpful review would be on > whether any of the affected files are normally generated, where either > we add exceptions, or fix the generator, so as to avoid regressions when > those files are regenerated. > > commit 4d3b7e06bc8e2e76584da369406df0909c63f2d4 > Author: Eric Blake <eblake@xxxxxxxxxx> > Date: Tue Mar 9 09:33:48 2010 -0700 > > build: consistently indent preprocessor directives > > * global: patch created by running: > for f in $(git ls-files '*.[ch]') ; do > cppi $f > $f.t && mv $f.t $f > done I'll go ahead and push this if no one speaks up soon. Rather than downloading and applying the patch, I ran the command and committed as you. For now, converting generated-and-VC'd files seems harmless. IMHO, it's fine to address any additional exceptions as they arise. >From 36d8e7d8d758e87b8889a1871a9d4a79b40fdd4a Mon Sep 17 00:00:00 2001 From: Eric Blake <eblake@xxxxxxxxxx> Date: Tue, 9 Mar 2010 19:22:22 +0100 Subject: [PATCH] build: consistently indent preprocessor directives * global: patch created by running: for f in $(git ls-files '*.[ch]') ; do cppi $f > $f.t && mv $f.t $f done --- daemon/dispatch.h | 4 +- daemon/event.h | 4 +- daemon/libvirtd.c | 126 ++-- ... -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list