On 6/16/21 10:02 AM, Lin Ma wrote:
> v1 -> v2:
> * 01-08 were merged, So remove them.
> * Reworked virshStorageVolKeyCompleter to avoid leaking objects.
>
> Thanks to Michal Privoznik for helping reviewing these patches.
>
> Lin Ma (5):
> virsh-pool: Remove static from virshStoragePoolList{Free,Collect}
> virsh-volume: Introduce virshStorageVolKeyCompleter
> virsh-volume: Add macros VIRSH_COMMON_OPT_VOL_*
> virsh-volume: Apply virshStorageVolKeyCompleter to vol-{name,pool}
> commands
> virsh-volume: Apply virshStorageVolNameCompleter to vol-{key,path}
> commands
>
> tools/virsh-completer-volume.c | 47 ++++++++++++++++++++++++++
> tools/virsh-completer-volume.h | 5 +++
> tools/virsh-pool.c | 10 ++----
> tools/virsh-pool.h | 11 +++++++
> tools/virsh-volume.c | 60 ++++++++++++++++------------------
> 5 files changed, 94 insertions(+), 39 deletions(-)
>
Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
and pushed.
Michal
