Re: [libvirt] [rebased PATCH 1/2] virsh: fix existing N_ uses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Eric Blake wrote:
> It is a bad idea to call gettext on an already-translated
> string.  In cases where a string must be translated separately
> from where it is exposed to xgettext, the gettext manual
> recommends the idiom of N_() wrapping gettext_noop for
> marking the string.
>
> * src/internal.h (N_): Fix definition to match gettext manual.
> * tools/virsh.c: (cmdHelp, cmdList, cmdDomstate, cmdDominfo)
> (cmdVcpuinfo, vshUsage): Replace incorrect use of N_ with _.
> (vshCmddefHelp): Likewise.  Mark C format strings appropriately.

Thanks.  I've pushed both of these.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]