On 6/15/21 2:38 AM, Lin Ma wrote: > Lin Ma (12): > virsh: Add comp-methods completion to migrate command > virsh: Use VIR_ENUM_* for --target argument in cmdNodeSuspend > virsh: Add target completion to nodesuspend command > virsh: Use VIR_ENUM_* for --target argument in cmdDomPMSuspend > virsh: Add target completion to dompmsuspend command > virsh: Add format completion to blockcopy command > virsh-pool: Add virshPoolTypeCompleter in macro > VIRSH_COMMON_OPT_POOL_X_AS > virsh-pool: Remove static from virshStoragePoolList{Free,Collect} > virsh-volume: Introduce virshStorageVolKeyCompleter > virsh-volume: Add macros VIRSH_COMMON_OPT_VOL_* > virsh-volume: Apply virshStorageVolKeyCompleter to vol-{name,pool} > commands > virsh-volume: Apply virshStorageVolNameCompleter to vol-{key,path} > commands > > tools/virsh-completer-domain.c | 37 +++++++++++++++++++++ > tools/virsh-completer-domain.h | 11 +++++++ > tools/virsh-completer-host.c | 20 ++++++++++++ > tools/virsh-completer-host.h | 4 +++ > tools/virsh-completer-volume.c | 53 ++++++++++++++++++++++++++++++ > tools/virsh-completer-volume.h | 5 +++ > tools/virsh-domain.c | 14 ++++---- > tools/virsh-domain.h | 1 + > tools/virsh-host.c | 18 +++++----- > tools/virsh-host.h | 3 ++ > tools/virsh-pool.c | 11 ++----- > tools/virsh-pool.h | 11 +++++++ > tools/virsh-volume.c | 60 ++++++++++++++++------------------ > 13 files changed, 193 insertions(+), 55 deletions(-) > ACK to 01-08. However, I'm pushing 01-07 only because 08 refers to 09 which needs to be reworked. Michal