On 5/19/21 3:03 PM, Peter Krempa wrote: > On Wed, May 19, 2021 at 12:16:57 +0200, Michal Privoznik wrote: >> Some of our really old APIs are missing @flags argument. We >> introduced their variants with "Flags" suffix and wired some >> logic into virsh to call the new variant only if necessary. This >> enables virsh to talk to older daemon which may be lacking new >> APIs. >> >> However, in case of cmdSetmem() we are talking about v0.1.1 >> (virDomainSetMemory()) vs. v0.9.0 (virDomainSetMemoryFlags()) and >> in case of cmdSetmaxmem() we are talking about v0.0.3 >> (virDomainSetMaxMemory()) vs v0.9.0 (virDomainSetMemoryFlags()). >> >> Libvirt v0.9.0 was released more than 10 years ago and recently >> we dropped support for RHEL-7 which has v4.5.0 (released ~3 years >> ago). Thus it is not really necessary to have support in virsh >> for such old daemons. >> >> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> >> --- >> tools/virsh-domain.c | 28 ++++++++-------------------- >> 1 file changed, 8 insertions(+), 20 deletions(-) > > Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx> > > While I agree with the premise, please hold off pushing this patch to > let others chime in. > Since nobody objected, I've pushed it. Michal
