On Wed, May 26, 2021 at 10:40:26AM -0500, Jonathon Jongsma wrote: > We supported autostart of node devices via an xml element, but this > is not consistent with other libvirt objects which use an explicit API > for setting autostart status. So revert this and implement it as an > official API in a future commit. > > The initial support was refactored after merging, so this commit reverts > both of those previous commits. > > Revert "virNodeDevCapMdevParseXML: Use virXMLPropEnum() for ./start/@type" > This reverts commit 9d4cd1d1cda84aa15b77a506f2ad6362a74edf1a. > > Revert "nodedev: support auto-start property for mdevs" > This reverts commit 42a558549935336cbdb7cbfe8b239ffb0e3442e3. > --- > docs/formatnode.html.in | 10 --------- > docs/schemas/nodedev.rng | 11 ---------- > src/conf/node_device_conf.c | 21 +------------------ > src/conf/node_device_conf.h | 12 ----------- > src/libvirt_private.syms | 2 -- > src/node_device/node_device_driver.c | 7 +------ > .../mdevctl-list-multiple.out.xml | 4 ---- > ...v_3627463d_b7f0_4fea_b468_f1da537d301b.xml | 10 +-------- > ...v_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml | 11 +--------- > 9 files changed, 4 insertions(+), 84 deletions(-) > mode change 100644 => 120000 tests/nodedevxml2xmlout/mdev_3627463d_b7f0_4fea_b468_f1da537d301b.xml > mode change 100644 => 120000 tests/nodedevxml2xmlout/mdev_ee0b88c4_f554_4dc1_809d_b2a01e8e48ad.xml Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|