On Tue, May 25, 2021 at 10:19:28PM -0400, Neal Gompa wrote: > On Tue, May 25, 2021 at 11:34 AM Andrea Bolognani <abologna@xxxxxxxxxx> wrote: > > On Tue, May 25, 2021 at 05:06:41PM +0200, Michal Prívozník wrote: > > > Wasn't the whole idea to drop dependencies? > > > > The point was to drop **build** dependencies, specifically > > problematic ones such as ZFS. When it comes to runtime dependencies, > > our RPMs generally try to be as featureful as possible, so adding a > > dependency on scrub is the right thing to do IMO. > > Why is ZFS problematic? The zfs-fuse package is totally fine for us to > depend on... I'm not too familiar with the ZFS situation in Fedora / RHEL, but at least in Debian we're patching meson.build specifically to enable ZFS support without needing a ZFS implementation available at build time. In general, using the build time availability of programs to guess whether features should be enabled is a good, user-friendly behavior, but we shouldn't second-guess the information provided by the user: if they passed -Dstorage_zfs=enabled to Meson, then we should enable ZFS support whether or not ZFS happens to be currently installed. -- Andrea Bolognani / Red Hat / Virtualization
