On 5/20/21 4:13 PM, Kristina Hanicova wrote: > This is v2 from: > https://listman.redhat.com/archives/libvir-list/2021-May/msg00481.html This is something we usually put [1] > > I have reworked the code a bit to have only one error report > instead of multiple ones with different combinations of possible > matching items. Suggested by Laine. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1942367 > > Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx> > --- 1: here. Right after these three dashes ^^^ and before diffstat. Everything that's above the dashes is a commit message, and everything that's after diff stat is patch, leaving this place for comments. BTW: this is also the place where git-notes would format notes (were there any). > src/conf/domain_conf.c | 67 ++++++++++++++++-------------------------- > 1 file changed, 25 insertions(+), 42 deletions(-) The patch looks good to me. I'll let Laine to express himself too since he was the one who suggested this approach. Michal
