According to Jim Meyering on 3/5/2010 10:27 AM:
> Here are three dead-store removals:
>
> Subject: [PATCH 1/3] xenXMDomainConfigParse: avoid dead store
>
> * src/xen/xm_internal.c (xenXMDomainConfigParse): Avoid dead store
> to local, "data". Remove declaration, too.
> @@ -1367,7 +1367,6 @@ xenXMDomainConfigParse(virConnectPtr conn, virConfPtr conf) {
> graphics->type = VIR_DOMAIN_GRAPHICS_TYPE_VNC;
>
> while (key) {
> - char *data;
> char *nextkey = strchr(key, ',');
> char *end = nextkey;
> if (nextkey) {
> @@ -1375,7 +1374,7 @@ xenXMDomainConfigParse(virConnectPtr conn, virConfPtr conf) {
> nextkey++;
> }
>
> - if (!(data = strchr(key, '=')))
> + if (!strchr(key, '='))
ACK to all 3
--
Eric Blake eblake@xxxxxxxxxx +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list