On 5/5/21 12:55 PM, Tim Wiederhake wrote: > For background, see > https://listman.redhat.com/archives/libvir-list/2021-April/msg00668.html > > V1: https://listman.redhat.com/archives/libvir-list/2021-April/msg01184.html > V2: https://listman.redhat.com/archives/libvir-list/2021-April/msg01238.html > > Changes since V2: > * Rebased > * Prepended patches to fix issues in the function > * Removed superfluous "VIR_XML_PROP_NONE" > > Tim Wiederhake (4): > virDomainFSDefParseXML: Remove unused variables > virDomainGraphicsDefParseXMLSpice: Fix variable type > virDomainGraphicsDefParseXMLSpice: Make name and mode mandatory > virDomainGraphicsDefParseXMLSpice: Use virXMLProp* > > src/conf/domain_conf.c | 195 +++++++++++++++++------------------------ > 1 file changed, 80 insertions(+), 115 deletions(-) > Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx> and pushed. Michal