Re: [PATCH v1 4/4] libxl: set vcpu affinity during domain creation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Tue, 4 May 2021 16:34:05 -0600
schrieb Jim Fehlig <jfehlig@xxxxxxxx>:

> > +    /* Will be released by libxl_domain_config_dispose */
> > +    b_info->vcpu_hard_affinity = calloc(vcpu_idx, sizeof(libxl_bitmap));  
> Fails syntax-check. You'll need to use g_new0.

There are other areas where libxl expects the caller to provide a malloc buffer, which it free's later in its *_dispose functions. libxlMakeDiskList for example.
This looks like an inconsistency in the API.

Perhaps we assume glib folks will make no mistakes in the future to use a private allocator again. Or we provide a simple calloc/free wrapper in libxl_api_wrapper.h, which can be easily blacklisted in exclude_file_name_regexp--sc_prohibit_raw_allocation.

Olaf

Attachment: pgp5CnQ2U58Nf.pgp
Description: Digitale Signatur von OpenPGP


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux