Re: [libvirt PATCH 4/6] tests: openvzutilstest: Remove duplicate linking with libvirt_openvz.a

[Pavel Hrdina <phrdina@xxxxxxxxxx>]

On Mon, May 03, 2021 at 12:01:44PM +0200, Tim Wiederhake wrote:
> "openvzutilstest" links, amongst others, against "libvirt_openvz.a" and
> "libvirt.so". The latter also links against "libvirt_openvz.a", leading
> to a One-Definition-Rule violation for "openvzLocateConfFile" in
> "openvz_conf.c".
> 
> Signed-off-by: Tim Wiederhake <twiederh@xxxxxxxxxx>
> ---
>  src/libvirt_openvz.syms | 2 ++
>  tests/meson.build       | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libvirt_openvz.syms b/src/libvirt_openvz.syms
> index ac0ed0d23e..a1038e51a4 100644
> --- a/src/libvirt_openvz.syms
> +++ b/src/libvirt_openvz.syms
> @@ -3,10 +3,12 @@
>  #
>  
>  # openvz/openvz_conf.h
> +openvzCapsInit;
>  openvzLocateConfFile;
>  openvzReadConfigParam;
>  openvzReadNetworkConf;
>  openvzVEGetStringParam;
> +openvzXMLOption;

This hunk should be in a separate patch as it fixes a different issue
where we did not list all required symbols.

Pavel

Attachment: signature.asc
Description: PGP signature