On Mon, Apr 26, 2021 at 09:55:05AM +0200, Peter Krempa wrote: > On Sun, Apr 25, 2021 at 17:33:31 +0800, Zhiyong Ye wrote: > > Limit the amount of ram below 4G. This can increase the address space > > used by PCI devices below 4G and it can be used by adding attributes in > > XML like this: > > <domain> > > ... > > <memory unit="MiB" below4g="2048">4096</memory> > > This illustrates that sharing the 'unit' argument between 'below4g' and > the actual memory size is wrong (pointed out also below). In case the > user modifies the unit but doesn't change below4g value it may be > misrepresented and since below4g is new some tools might not actually > know how to handle that. > > below4g must either be by default in kiB, or have an own unit (which > will probably be ugly). Why would we want to pick different units for the two values. Feels like it is overkill, and the same units value just applies to everything on this element. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
