Re: [PATCH] qemu: Don't double free @node_cpus in qemuProcessSetupPid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/23/21 10:56 AM, Ján Tomko wrote:
On a Friday in 2021, Michal Privoznik wrote:
When placing vCPUs into CGroups the qemuProcessSetupPid() is
called which then enters a for() loop (around its middle) where
it calls virDomainNumaGetNodeCpumask() for each guest NUMA node.
But the latter returns only a pointer not new reference/copy and
thus the caller must not free it. But the variable is decorated
with g_autoptr() which leads to a double free.

Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Fixes: 2d37d8dbc987d1998b4ad8029ba324b6bfe49799

Yeah, I thought about adding it here, but then figured it's int the same release as this patch is going to be. And I guess nobody backports features. So what are the rules for putting "fixes"?


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Pushed, thanks.

Michal




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux