On Mon, 2021-04-19 at 13:35 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 16, 2021 at 09:12:45PM +0200, Pavel Hrdina wrote:
> > - if not get_option('storage_iscsi').disabled() and iscsiadm_prog.found()
> > + if not get_option('storage_iscsi').disabled()
> > use_storage = true
> > conf.set('WITH_STORAGE_ISCSI', 1)
>
> So this now enables iSCSI even on platforms which don't support iscsiadm
> tools.
>
> > + use_storage = true
> > + conf.set('WITH_STORAGE_LVM', 1)
>
> And enables LVM on all platforms, even though this is Linux only..
>
> Overall this patch makes it so that our meson rules don't
> "do the right thing" as a default behaviour, and just enable
> everything whether you have it installed or not.
Can't we address that by implementing explicit OS checks?
Right now we're using "the iscsiadm command happens to be installed
on the build host" as a proxy for "the iscsiadm command will be
available on the deployment host", which is not a bad approximation
but is not quite right either.
--
Andrea Bolognani / Red Hat / Virtualization
