Re: [libvirt PATCH v4 2/8] virxml: Add virXMLPropTristateSwitch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 08, 2021 at 10:57:04 +0200, Tim Wiederhake wrote:
> Convenience function to return the value of an on / off XML attribute.
> 
> Signed-off-by: Tim Wiederhake <twiederh@xxxxxxxxxx>
> ---
>  src/libvirt_private.syms |  1 +
>  src/util/virxml.c        | 49 ++++++++++++++++++++++++++++++++++++++++
>  src/util/virxml.h        |  4 ++++
>  3 files changed, 54 insertions(+)

See comments on previous patch. Otherwise looks good so you can use my

Reviewed-by: Peter Krempa <pkrempa@xxxxxxxxxx>

if you fix it similarly to the previously requested changes.




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux