On Thu, Apr 15, 2021 at 02:44:09PM +0200, Andrea Bolognani wrote: > On Thu, 2021-04-15 at 11:10 +0100, Daniel P. Berrangé wrote: > > On Thu, Apr 15, 2021 at 11:36:19AM +0200, Michal Privoznik wrote: > > > The -client package needs then to obsolete those packages which you're > > > removing. Loo around at "Obsoletes:" tag we have around. > > > > Also needs a Provides tag to satisy any deps other packages have on it > > Makes sense, will do. > > > > However, I'm not sure that virt-admin should go to client package. For > > > instance, I can install -client to control remote daemon but virt-admin > > > works only locally (because we want it to). Therefore, if anything, it > > > should go in the same package as libvirtd. But taking split daemons into > > > account - any of them should drag in virt-admin. > > Some of the things that currently live in the -client package are > also local-only: virt-host-validate, virt-pki-validate and > libvirt-guests. I agree that the distinction is not entirely > clear-cut, but virt-admin fits slightly better in -client than in > -daemon IMHO. Those existing things are arguably in the wrong place too, but I guess no one cared as they're just small shell scripts. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
