Re: [RFC PATCH 2/7] qemuMigrationCookieNBDXMLFormat: Format empty <nbd/> element

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2021-04-13 at 17:38 +0200, Peter Krempa wrote:
> -    virXMLFormatElement(buf, "nbd", &attrBuf, &childBuf);
> +    virXMLFormatElementEmpty(buf, "nbd", &attrBuf, &childBuf);

The explanation in the commit message is good, but I think having at
least a very short nod in the code itself would be nice.

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux