Re: [PATCH 2/6] nodedev: Wait for device initialization in nodeDeviceCreate()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 13, 2021 at 12:01:53PM +0200, Michal Privoznik wrote:
> Although I have not experienced this in real life, there is a
> possible race condition when creating new device. If the nodedev
> driver is still enumerating devices (in a separate thread) and
> virNodeDeviceCreate() is called then it can lead to spurious
> results because the device enumeration thread is removing devices
> from or adding them to the internal list of devices (among with
> their states).
> 
> Therefore, wait for things to settle down before proceeding with
> nodeDeviceCreate().

Hmm, correct. Looking at the source - nodeDeviceGetXMLDesc,
nodeDeviceGetParent and nodeDeviceNumOfCaps are the only exceptions as far as
public API mappings go. Would you mind extending this patch?

Erik




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux