On Tue, Apr 13, 2021 at 01:13:41PM +0200, Peter Krempa wrote: > On Tue, Apr 13, 2021 at 13:09:15 +0200, Pavel Hrdina wrote: > > On Tue, Apr 13, 2021 at 12:53:23PM +0200, Peter Krempa wrote: > > > On Tue, Apr 13, 2021 at 11:10:18 +0200, Pavel Hrdina wrote: > > > > The comment for that option states that the default value is 'none' but > > > > it was not set by the code. > > > > > > > > Fixes: 700450449377be4bf923e91d00f8fe8cf0975f66 > > > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > > > > --- > > > > > > Could you please elaborate what the problem of not setting it is? > > > > > > 'none' the same as NULL should result in doing nothing. > > > > When the config is not set in qemu.conf libvirt will print the following > > warning if there is any deprecated command used: > > > > warning : qemuBuildCompatDeprecatedCommandLine:10393 : Unsupported deprecation behavior '(null)' for VM 'test' > > > > So no NULL and 'none' are not the same. > > > > We could fix qemuBuildCompatDeprecatedCommandLine() but I figured that > > this is what we do with other options so that would be preferred > > solution. > > Sure. I agree, but as I've noted in reply to Michal, such explanation > should be part of the commit message. I figured that what I wrote into commit message was good enough, I'll add the warning message in the commit message before pushing. Pavel
Attachment:
signature.asc
Description: PGP signature
