On Fri, Mar 26, 2021 at 11:48:19AM -0500, Jonathon Jongsma wrote: > This new API function provides a way to start a persistently-defined > mediate device that was defined by virNodeDeviceDefineXML() (or one that > was defined externally via mdevctl) > > Signed-off-by: Jonathon Jongsma <jjongsma@xxxxxxxxxx> > Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> > --- > include/libvirt/libvirt-nodedev.h | 2 + > src/driver-nodedev.h | 4 ++ > src/libvirt-nodedev.c | 35 ++++++++++ > src/libvirt_public.syms | 1 + > src/node_device/node_device_driver.c | 68 ++++++++++++++++++++ > src/node_device/node_device_driver.h | 7 ++ > src/node_device/node_device_udev.c | 1 + > src/remote/remote_driver.c | 1 + > src/remote/remote_protocol.x | 13 +++- > src/remote_protocol-structs | 4 ++ > tests/nodedevmdevctldata/mdevctl-create.argv | 1 + > tests/nodedevmdevctltest.c | 11 +++- > 12 files changed, 146 insertions(+), 2 deletions(-) > create mode 100644 tests/nodedevmdevctldata/mdevctl-create.argv > > diff --git a/include/libvirt/libvirt-nodedev.h b/include/libvirt/libvirt-nodedev.h > index 623017f1fd..cf51c3d085 100644 > --- a/include/libvirt/libvirt-nodedev.h > +++ b/include/libvirt/libvirt-nodedev.h > @@ -137,6 +137,8 @@ virNodeDevicePtr virNodeDeviceDefineXML(virConnectPtr conn, > > int virNodeDeviceUndefine(virNodeDevicePtr dev); > > +int virNodeDeviceCreate(virNodeDevicePtr dev); This API has the same problem of missing "unsigned int flags" and is even more critical for the Create method IMHO. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
