Re: [libvirt PATCH] meson: remove obsolete comment about stack frame size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 08, 2021 at 02:00:16PM +0100, Daniel P. Berrangé wrote:
> The virStrerror function no longer exists in libvirt so is not a
> constraint. At the current stack limit of 4k, and default Linux
> stack size of 8 MB, we have a recursion limit of 2048 in the
> absolute worst case, and much higher in common case. Even with
> smaller stack sizes, we're going to be fine as we don't deeply
> recurse in code.
> 
> Thus it is not worth spending effort to optimize below our current
> 4k worst case limit. Removing the comment will stop encouraging
> people to spend time on this in future.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  meson.build | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux