On Thu, Apr 01, 2021 at 11:44:59AM -0600, Jim Fehlig wrote: > If QEMU_AUDIO_DRV is defined in the build host environment, several tests > in qemuxml2xmltest fail. > > $ env | grep -i audio > AUDIODRIVER=pulseaudio > QEMU_AUDIO_DRV=pa > SDL_AUDIODRIVER=pulse > > An example test failure with the above environment > > 907) QEMU XML-2-XML-active video-virtio-gpu-sdl-gl > In 'libvirt/tests/qemuxml2xmloutdata/video-virtio-gpu-sdl-gl.xml': > Offset 1244 > Expect [v] > Actual [audio id='1' type='pulseaudio'/> > <v] > > Scrub QEMU_AUDIO_DRV from the environment before executing the tests in > qemuxml2xmltest. SDL_AUDIODRIVER also needs scrubbed since it will be > examined if QEMU_AUDIO_DRV=sdl. > > Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxx> > --- > > v2: Also scrub SDL_AUDIODRIVER > > tests/qemuxml2xmltest.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
