On Wed, 2021-03-31 at 23:31 +0200, Martin Kletzander wrote: > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > We should always pass --werror and display the contents of the > > log file in case of failure. > > Any reason why the lines are not in one place? What I did in libnbd > (first draft, still up for review) is that I just took all the lines of > the script and put them inside `ci/build_script.sh` with only the most > basic conditionals to accommodate various types of runs. That way > common things are in one place. It could take a parameter (like what > ninja target to run) and you can run things after that (like `website` > and `potfiles` jobs do. Just an idea. As is often the case, the raisins are mostly hysterical ;) I think the initial idea was to keep things as simple as possible, but I agree with you that when you have seven (!) build recipes, most of which are almost identical, it makes sense to think about consolidating them to a single location. -- Andrea Bolognani / Red Hat / Virtualization
