On a Wednesday in 2021, Kristina Hanicova wrote:
Previously, we accepted empty bridge name, because some old versions of VMWare Workstation did not put it into the config. But this doesn't make much sense - to have an interface type bridge with no name. We circumvented this problem by generating an empty name but that is equally wrong. Therefore, fill in missing bridge names (according to the documentation [1] the default bridge name is VMnet0) and error out if bridge name is missing. This partially reverts f246cdb5aca13ac9409b2ad43087e3078615ffcb 1: https://docs.vmware.com/en/VMware-Workstation-Player-for-Linux/16.0/com.vmware.player.linux.using.doc/GUID-BAFA66C3-81F0-4FCA-84C4-D9F7D258A60A.html Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx> --- src/vmx/vmx.c | 10 +++------- tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.vmx | 2 ++ tests/vmx2xmldata/vmx2xml-fusion-in-the-wild-1.xml | 4 ++-- tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.vmx | 1 + tests/vmx2xmldata/vmx2xml-ws-in-the-wild-2.xml | 2 +- tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.vmx | 2 ++ tests/xml2vmxdata/xml2vmx-fusion-in-the-wild-1.xml | 4 ++-- tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.vmx | 1 + tests/xml2vmxdata/xml2vmx-ws-in-the-wild-2.xml | 2 +- 9 files changed, 15 insertions(+), 13 deletions(-)
Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx> Jano
Attachment:
signature.asc
Description: PGP signature
