Re: [PATCH] news: Update for upcoming release

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2021-03-31 at 16:20 +0200, Michal Privoznik wrote:
> +  * Add support for audio backend specific settings
> +
> +    With this release new ``<audio/>`` element is introduced that allows users
> +    to configure audio output for their guests.

s/new/ a new/

> +  * Various improvements for embed driver
> +
> +    The embed driver and ``virt-qemu-run`` tool saw improvements in handling of
> +    domain life cycle, temporary directories creation (important when using
> +    disk secrets) and other minor fixes.

Perhaps a nit, but "embed driver" makes it sound like it's a separate
hypervisor driver, when in reality it's just the QEMU driver running
in embedded mode.

I suggest reworking this along the lines of

  qemu: Various improvements to embedded mode

  Embedded mode for the QEMU driver, as well as the
  ``virt-qemu-run`` tool, saw improvements [...]

> +  * Check host cpu for forbidden features

s/cpu/CPU/

> +    CPU feature policy did not work as expected with host-passthrough and

s/host-passthrough/``host-passthrough``/

> +  * virNetworkUpdate() can not work with the split daemon

This describes the original issue rather than the fix that was
applied to address it. Maybe use something like

  * Fix virNetworkUpdate() to work with split daemons

> +    Due to a bug in our code, virNetworkUpdate() did not work with split daemon
> +    unless management application connected to virtnetworkd directly.

s/virNetworkUpdate()/``virNetworkUpdate()``/

> +  * qemu: Only raise memlock limit if necessary
> +
> +    Attempting to set the memlock limit might fail if we're running
> +    in a containerized environment where CAP_SYS_RESOURCE is not
> +    available, and if the limit is already high enough there's no
> +    point in trying to raise it anyway.

s/CAP_SYS_RESOURCE/``CAP_SYS_RESOURCE``/

> +  * Restore security context of swtpm.log
> +
> +    If a guest with emulated TPM was started and the daemon was restarted
> +    afterwards, the security context of per domain swtmp.log file was not
> +    restored on domain shutdown leaving it unable to be started again.

s/per domain swtmp.log/the per-domain ``swtpm.log``/


Thanks a lot for taking care of this!

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux