On Fri, Mar 26, 2021 at 05:11:04PM +0100, Andrea Bolognani wrote: > On Fri, 2021-03-26 at 17:00 +0100, Erik Skultety wrote: > > On Fri, Mar 26, 2021 at 11:35:02AM +0100, Andrea Bolognani wrote: > > > We should always pass --werror and display the contents of the > > > log file in case of failure. > > > > > > Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx> > > > --- > > Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx> > > Even though you didn't spell that out explicitly, I assume you're > okay with me pushing this series during the freeze? I know it's trivial and most likely will not affect the release at all but my understanding of freeze is that we try to stabilize the build by fixing bugs or any issues that would prevent us to deliver the final release. To me that sounds like reasonable definition that we should try to follow and in my mind creates a clear decision process if something should/can be pushed during freeze. Based on that definition I would say that these patches does not qualify and can easily wait once the release is done. Pavel
Attachment:
signature.asc
Description: PGP signature
