On Wed, Mar 10, 2021 at 06:01:17PM +0100, Kristina Hanicova wrote:
With this, incomplete XML without <frames/> for <rx/> in coalesce won't raise error as before. It will leave the coalesce parameter empty, thanks to passing it as a parameter and return an integer to indicate error state - previously it returned pointer (or NULL for both error and incomplete XML). I also added a test case to test this functionality in the qemuxml2xmltest. The code went through some refactoring: * change of a condition * addition of a parameter * change of order, that allowed removal of VIR_FREE * removal of redundant labels and variables Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1535930 Signed-off-by: Kristina Hanicova <khanicov@xxxxxxxxxx> ---
Reviewed-by: Martin Kletzander <mkletzan@xxxxxxxxxx> And pushed now.
Attachment:
signature.asc
Description: PGP signature