On 3/22/21 5:09 PM, Tim Wiederhake wrote:
virsh has several arguments that are better not used. This series introduces a formal way of marking them as deprecated.
Commit messages are rather sparse. What we currently have is hiding options we deem obsolete from users and replacing them with better ones (just :Ggrep VSH_OT_ALIAS). No error message, no warning. What makes these you picked special? I'm not against reporting that an option is obsolete, but I don't quite understand why we need a different way for obsoleting those three.
I think plain warning reported in vshCmddefGetOption() would be just fine, wouldn't it? I don't think that ERROR level is justified for this - if I run `virsh -q` from a script I don't want to be bothered.
Michal
