The XML formatter validation was missing for this code path. Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> --- .../qemu-ns.x86_64-latest.xml | 51 +++++++++++++++++++ tests/qemuxml2xmltest.c | 1 + 2 files changed, 52 insertions(+) create mode 100644 tests/qemuxml2xmloutdata/qemu-ns.x86_64-latest.xml diff --git a/tests/qemuxml2xmloutdata/qemu-ns.x86_64-latest.xml b/tests/qemuxml2xmloutdata/qemu-ns.x86_64-latest.xml new file mode 100644 index 0000000000..53e21edfaf --- /dev/null +++ b/tests/qemuxml2xmloutdata/qemu-ns.x86_64-latest.xml @@ -0,0 +1,51 @@ +<domain type='qemu' xmlns:qemu='http://libvirt.org/schemas/domain/qemu/1.0'> + <name>QEMUGuest1</name> + <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid> + <memory unit='KiB'>219136</memory> + <currentMemory unit='KiB'>219136</currentMemory> + <vcpu placement='static'>1</vcpu> + <os> + <type arch='i686' machine='pc'>hvm</type> + <boot dev='hd'/> + </os> + <cpu mode='custom' match='exact' check='none'> + <model fallback='forbid'>qemu64</model> + </cpu> + <clock offset='utc'/> + <on_poweroff>destroy</on_poweroff> + <on_reboot>restart</on_reboot> + <on_crash>destroy</on_crash> + <devices> + <emulator>/usr/bin/qemu-system-i386</emulator> + <disk type='block' device='disk'> + <driver name='qemu' type='raw'/> + <source dev='/dev/HostVG/QEMUGuest1'/> + <target dev='hda' bus='ide'/> + <address type='drive' controller='0' bus='0' target='0' unit='0'/> + </disk> + <controller type='ide' index='0'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x1'/> + </controller> + <controller type='usb' index='0' model='piix3-uhci'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/> + </controller> + <controller type='pci' index='0' model='pci-root'/> + <input type='mouse' bus='ps2'/> + <input type='keyboard' bus='ps2'/> + <audio id='1' type='none'/> + <memballoon model='virtio'> + <address type='pci' domain='0x0000' bus='0x00' slot='0x02' function='0x0'/> + </memballoon> + </devices> + <qemu:commandline> + <qemu:arg value='-unknown'/> + <qemu:arg value='parameter'/> + <qemu:env name='NS' value='ns'/> + <qemu:env name='BAR'/> + </qemu:commandline> + <qemu:capabilities> + <qemu:add capability='vnc-colon'/> + <qemu:add capability='blockdev'/> + <qemu:del capability='name'/> + </qemu:capabilities> +</domain> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index 4e7cce21c6..d4beb12e22 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -277,6 +277,7 @@ mymain(void) DO_TEST("restore-v2", NONE); DO_TEST("migrate", NONE); DO_TEST("qemu-ns-no-env", NONE); + DO_TEST_CAPS_LATEST("qemu-ns"); DO_TEST("disk-aio", NONE); DO_TEST_CAPS_LATEST("disk-aio-io_uring"); DO_TEST("disk-cdrom", NONE); -- 2.29.2
