Re: [libvirt PATCH v3 6/6] ci: helper: Convert private methods to Python common naming practice

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 18, 2021 at 12:09:19PM +0100, Andrea Bolognani wrote:
> On Thu, 2021-03-18 at 09:09 +0100, Erik Skultety wrote:
> > As documented at [1], the common practice wrt to private
> 
> s/wrt to/with respect to/
> 
> >      def parse(self):
> >          return self.parser.parse_args()
> 
> Shouldn't this change be applied to Parser.parser...
> 
> >      def run(self):
> >          self.args.func(self)
> 
> ... and Application.args too?
> 
> Everything else looks good.

Applied.

Erik




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux